Directly use the embedded sv instead of the init symlinks.

[matthiasr]

The symlinks in init/ are created by the runit cookbook, and on Debian
it creates a wrapper script instead of simple symlinks. This wrapper
script encodes /usr/bin/sv as the control binary.

Instead of relying on the symlinks being as expected, directly use the
binary that is embedded anyway.

Fixes #53. Fixes running chef-server on Debian.

[matthiasr]

I verified that this works by cloning this repository, installing chef-server-core and then installing the gem into it:

dpkg -i chef-server*.deb
/opt/opscode/embedded/bin/gem install omnibus-ctl-0.5.0.gem
chef-server-ctl reconfigure
chef-server-ctl status

on a fresh Debian Jessie VM.

[srenatus]

I don't see any reason it should do anything but this.

👍 thanks.

more information -- retracting my review

[srenatus]

From sv(8):

sv exits 0, if the command was successfully sent to all services, and, if it was told to wait, the command has taken effect to all services.

If sv is called with a base name other than sv: it exits 1 on timeout or trouble sending the command; if the command is status, it exits 3 if the service is down, and 4 if the status is unknown; it exits 2 on wrong usage, and 151 on error.

This means calling sv directly will always return 0 (unless stuff is terribly wrong) -- this would break the expectation of omnibus-ctl. It seems like we would either have to change the basename or parse the output. Both seems rather brittle compared to the what was the behaviour before.

[matthiasr]

Damn, that's unfortunate. I know why I don't like switching on $0 …