[metricbeat] Add creation timestamp to state_persistentvolumeclaim me…

…tricset (elastic#37108) * [metricbeat] Add creation timestamp to state_persistentvolumeclaim metricset
chemamartinez · Nov 14, 2023 · 921dede · 921dede
1 parent 66fd810
commit 921dede
Show file tree

Hide file tree

Showing 12 changed files with 25 additions and 4 deletions.
diff --git a/metricbeat/docs/fields.asciidoc b/metricbeat/docs/fields.asciidoc
@@ -46316,7 +46316,7 @@ type: keyword
 [float]
 === persistentvolumeclaim
 
-kubernetes persistent volume clame metrics from kube-state-metrics
+kubernetes persistent volume claim metrics from kube-state-metrics
 
 
 
@@ -46374,6 +46374,15 @@ type: keyword
 
 --
 
+*`kubernetes.persistentvolumeclaim.created`*::
++
+--
+PersistentVolumeClaim creation date
+
+type: date
+
+--
+
 [float]
 === pod
 

diff --git a/metricbeat/module/kubernetes/fields.go b/metricbeat/module/kubernetes/fields.go
diff --git a/metricbeat/module/kubernetes/state_persistentvolumeclaim/_meta/data.json b/metricbeat/module/kubernetes/state_persistentvolumeclaim/_meta/data.json
@@ -9,6 +9,7 @@
         "namespace": "default",
         "persistentvolumeclaim": {
             "access_mode": "ReadWriteOnce",
+            "created": "2023-10-31T11:19:20.000Z",
             "name": "task-pv-claim",
             "phase": "Bound",
             "request_storage": {

diff --git a/metricbeat/module/kubernetes/state_persistentvolumeclaim/_meta/fields.yml b/metricbeat/module/kubernetes/state_persistentvolumeclaim/_meta/fields.yml
@@ -1,7 +1,7 @@
 - name: persistentvolumeclaim
   type: group
   description: >
-    kubernetes persistent volume clame metrics from kube-state-metrics
+    kubernetes persistent volume claim metrics from kube-state-metrics
   release: ga
   fields:
     - name: name
@@ -22,4 +22,7 @@
     - name: storage_class
       type: keyword
       description: Storage class for the PVC.
-
+    - name: created
+      type: date
+      description: PersistentVolumeClaim creation date
+
diff --git a/...cbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.10.0.plain.expected b/...cbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.10.0.plain.expected
@@ -6,6 +6,7 @@
 		},
 		"MetricSetFields": {
 			"access_mode": "ReadWriteOnce",
+			"created": "2023-10-31T11:19:20.000Z",
 			"name": "task-pv-claim",
 			"phase": "Bound",
 			"request_storage": {

diff --git a/...icbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.8.2.plain.expected b/...icbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.8.2.plain.expected
@@ -6,6 +6,7 @@
 		},
 		"MetricSetFields": {
 			"access_mode": "ReadWriteOnce",
+			"created": "2023-08-09T08:06:42.000Z",
 			"name": "task-pv-claim",
 			"phase": "Bound",
 			"request_storage": {

diff --git a/...icbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.9.2.plain.expected b/...icbeat/module/kubernetes/state_persistentvolumeclaim/_meta/test/ksm.v2.9.2.plain.expected
@@ -6,6 +6,7 @@
 		},
 		"MetricSetFields": {
 			"access_mode": "ReadWriteOnce",
+			"created": "2023-08-09T08:08:46.000Z",
 			"name": "task-pv-claim",
 			"phase": "Bound",
 			"request_storage": {

diff --git a/...eat/module/kubernetes/state_persistentvolumeclaim/_meta/testdata/docs.plain-expected.json b/...eat/module/kubernetes/state_persistentvolumeclaim/_meta/testdata/docs.plain-expected.json
@@ -9,6 +9,7 @@
             "namespace": "default",
             "persistentvolumeclaim": {
                 "access_mode": "ReadWriteOnce",
+                "created": "2023-10-31T11:19:20.000Z",
                 "name": "task-pv-claim",
                 "phase": "Bound",
                 "request_storage": {

diff --git a/...ule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.10.0.plain-expected.json b/...ule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.10.0.plain-expected.json
@@ -9,6 +9,7 @@
             "namespace": "default",
             "persistentvolumeclaim": {
                 "access_mode": "ReadWriteOnce",
+                "created": "2023-10-31T11:19:20.000Z",
                 "name": "task-pv-claim",
                 "phase": "Bound",
                 "request_storage": {

diff --git a/...dule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.8.2.plain-expected.json b/...dule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.8.2.plain-expected.json
@@ -9,6 +9,7 @@
             "namespace": "default",
             "persistentvolumeclaim": {
                 "access_mode": "ReadWriteOnce",
+                "created": "2023-08-09T08:06:42.000Z",
                 "name": "task-pv-claim",
                 "phase": "Bound",
                 "request_storage": {

diff --git a/...dule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.9.2.plain-expected.json b/...dule/kubernetes/state_persistentvolumeclaim/_meta/testdata/ksm.v2.9.2.plain-expected.json
@@ -9,6 +9,7 @@
             "namespace": "default",
             "persistentvolumeclaim": {
                 "access_mode": "ReadWriteOnce",
+                "created": "2023-08-09T08:08:46.000Z",
                 "name": "task-pv-claim",
                 "phase": "Bound",
                 "request_storage": {

diff --git a/metricbeat/module/kubernetes/state_persistentvolumeclaim/state_persistentvolumeclaim.go b/metricbeat/module/kubernetes/state_persistentvolumeclaim/state_persistentvolumeclaim.go
@@ -29,6 +29,7 @@ var mapping = &p.MetricsMapping{
 	Metrics: map[string]p.MetricMap{
 
 		"kube_persistentvolumeclaim_access_mode": p.LabelMetric("access_mode", "access_mode"),
+		"kube_persistentvolumeclaim_created":     p.Metric("created", p.OpUnixTimestampValue()),
 		"kube_persistentvolumeclaim_info":        p.InfoMetric(),
 		"kube_persistentvolumeclaim_labels": p.ExtendedInfoMetric(
 			p.Configuration{