Skip to content

Commit

Permalink
[O11y][Salesforce] Add support of the interval parameter in Salesfo…
Browse files Browse the repository at this point in the history
…rce `setupaudittrail-rest` fileset. (elastic#35938)

* add interval for setupaudittrail fileset

* add changelog.asciidoc entry

* add changelog.next.asciidoc entry

* run make check command

* run make update command

* update note as per review comment

* make check command

* remove CHANGELOG.asciidoc entry
  • Loading branch information
kush-elastic authored Aug 14, 2023
1 parent bb0bf78 commit c7d587c
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ automatic splitting at root level, if root level element is an array. {pull}3415
- Allow parsing bytes in and bytes out as long integer in CEF processor. {issue}36100[36100] {pull}36108[36108]
- Add support for registered owners and users to AzureAD entity analytics provider. {pull}36092[36092]
- Added support for Okta OAuth2 provider in the httpjson input. {pull}36273[36273]
- Add support of the interval parameter in Salesforce setupaudittrail-rest fileset. {issue}35917[35917] {pull}35938[35938]

*Auditbeat*

Expand Down
7 changes: 7 additions & 0 deletions filebeat/docs/modules/salesforce.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Example config:
var.user: "[email protected]"
var.password: "password"
var.url: "https://instance-url.salesforce.com"
var.interval: 1h
----

include::../include/var-paths.asciidoc[]
Expand Down Expand Up @@ -253,6 +254,12 @@ The password used as part of the authentication flow. It is required for authent

The URL of the Saleforce instance.

*`var.interval`*::

Period of fetching logs, i.e. 1s/1m/1h.

Note: The default value of `var.interval` is 1h. It is important to exercise caution when reducing the interval, as it directly affects the API rate limit of the Salesforce instance. Salesforce API rate limit is ~1000 API calls per hour. Hence if user goes with lower limit of var.interval, the Salesforce API rate limit will exceed and any additional API requests beyond the limit will result in an error response from the Salesforce API. The error message will typically indicate that the rate limit has been exceeded. Please refer to the following link for the https://developer.salesforce.com/docs/atlas.en-us.salesforce_app_limits_cheatsheet.meta/salesforce_app_limits_cheatsheet/salesforce_app_limits_platform_api.htm[Salesforce API Rate Limit].

[float]
==== `apex-rest` fileset settings

Expand Down
4 changes: 3 additions & 1 deletion x-pack/filebeat/filebeat.reference.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1999,7 +1999,9 @@ filebeat.modules:

# URL, should include the instance_url
#var.url: "https://instance_id.my.salesforce.com"


# Interval, should include the time interval
#var.interval: 1h
#----------------------------- Google Santa Module -----------------------------
- module: santa
log:
Expand Down
3 changes: 3 additions & 0 deletions x-pack/filebeat/module/salesforce/_meta/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,6 @@

# URL, should include the instance_url
#var.url: "https://instance_id.my.salesforce.com"

# Interval, should include the time interval
#var.interval: 1h
7 changes: 7 additions & 0 deletions x-pack/filebeat/module/salesforce/_meta/docs.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ Example config:
var.user: "[email protected]"
var.password: "password"
var.url: "https://instance-url.salesforce.com"
var.interval: 1h
----

include::../include/var-paths.asciidoc[]
Expand Down Expand Up @@ -246,6 +247,12 @@ The password used as part of the authentication flow. It is required for authent

The URL of the Saleforce instance.

*`var.interval`*::

Period of fetching logs, i.e. 1s/1m/1h.

Note: The default value of `var.interval` is 1h. It is important to exercise caution when reducing the interval, as it directly affects the API rate limit of the Salesforce instance. Salesforce API rate limit is ~1000 API calls per hour. Hence if user goes with lower limit of var.interval, the Salesforce API rate limit will exceed and any additional API requests beyond the limit will result in an error response from the Salesforce API. The error message will typically indicate that the rate limit has been exceeded. Please refer to the following link for the https://developer.salesforce.com/docs/atlas.en-us.salesforce_app_limits_cheatsheet.meta/salesforce_app_limits_cheatsheet/salesforce_app_limits_platform_api.htm[Salesforce API Rate Limit].

[float]
==== `apex-rest` fileset settings

Expand Down
3 changes: 3 additions & 0 deletions x-pack/filebeat/modules.d/salesforce.yml.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,6 @@

# URL, should include the instance_url
#var.url: "https://instance_id.my.salesforce.com"

# Interval, should include the time interval
#var.interval: 1h

0 comments on commit c7d587c

Please sign in to comment.