Devcontainer tooling improvements (mlflow#12511)

Signed-off-by: Jonathan Giannuzzi <[email protected]> Signed-off-by: Ben Wilson <[email protected]> Co-authored-by: Ben Wilson <[email protected]>
chenmoneygithub · Oct 3, 2024 · 73a64db · 73a64db
1 parent 63ca2de
commit 73a64db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.devcontainer/Dockerfile.devcontainer b/.devcontainer/Dockerfile.devcontainer
@@ -70,3 +70,6 @@ RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | s
 RUN curl https://github.com/jgm/pandoc/releases/download/3.1.9/pandoc-3.1.9-1-${TARGETPLATFORM#*/}.deb -L -o /tmp/pandoc.deb \
     && sudo dpkg -i /tmp/pandoc.deb \
     && rm /tmp/pandoc.deb
+
+# Install taplo
+RUN npm install -g @taplo/cli
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -13,11 +13,15 @@
         "editor.rulers": [80, 100],
         "editor.formatOnSave": true,
         "editor.formatOnSaveTimeout": 5000,
+        "git.alwaysSignOff": true,
         "python.defaultInterpreterPath": "/usr/local/bin/python",
         "python.analysis.autoImportCompletions": false,
         "[python]": {
-          "editor.defaultFormatter": "charliermarsh.ruff",
-          "editor.formatOnSave": true
+          "editor.codeActionsOnSave": {
+            "source.fixAll": "explicit",
+            "source.organizeImports": "explicit"
+          },
+          "editor.defaultFormatter": "charliermarsh.ruff"
         },
         "python.formatting.provider": "none",
         "prettier.prettierPath": "/workspaces/mlflow/mlflow/server/js/node_modules/prettier",
@@ -35,9 +39,11 @@
         "ms-python.python",
         "ms-toolsai.jupyter",
         "oderwat.indent-rainbow",
+        "pbkit.vscode-pbkit",
         "PKief.material-icon-theme",
         "ritwickdey.LiveServer",
-        "shardulm94.trailing-spaces"
+        "shardulm94.trailing-spaces",
+        "tamasfe.even-better-toml"
       ]
     }
   }