Merge pull request #19 from cheonhyangzhang/feat/13

[feat/13] Multiple element is sharing the variable if no initial var…
cheonhyangzhang · Sep 14, 2016 · 4dfc97a · 4dfc97a
2 parents 41eb51c + 939b07f
commit 4dfc97a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/paper-tags-input.html b/paper-tags-input.html
@@ -103,7 +103,7 @@ <h3>{{label}}</h3>
       tags:{
         type:Array,
         notify: true,
-        value:[],
+        value:function(){return []},
       },
       /**
       * the CSS color for the tag, e.g. #e5e5e5

diff --git a/test/basic-test.html b/test/basic-test.html
@@ -45,6 +45,12 @@
       </template>
     </test-fixture>
 
+    <test-fixture id="wrong-tags">
+      <template>
+        <paper-tags-input> </paper-tags-input>
+      </template>
+    </test-fixture>
+
     <script>
       suite('<paper-tags-input>', function() {
         var myEl;
@@ -96,11 +102,16 @@
         setup(function() {
           myEl = fixture('duplicate');
         });
+        test('multiple paper-tags-input in the same page should not share tags variable when tags property is not given', function() {
+          assert.equal(myEl.tags.length, 0);
+          assert.deepEqual(myEl.tags, []);
+        });
         test('should not allow to add duplicate tag', function() {
-          // myEl._addTag("Hello World");
-          // myEl._addTag("Hello World");
+          // assert.deepEqual(myEl.tags, []);
+          // myEl._addTag('QianBenLuLu');
           // assert.deepEqual(myEl.tags[0], 'QianBenLuLu');
-          // assert.equal(myEl.tags.length, 1);
+          // assert.deepEqual(myEl.tags.length, 1);
+          // myEl._addTag('QianBenLuLu');
           // var input = myEl.querySelector('paper-input');
           // assert.equal(input.errorMessage, myEl.duplicateErrorMessage);
           // assert.equal(input.invalid, true);