Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotImplementedError in TestLaserSpectrum unit test #417

Closed
vsnever opened this issue Aug 9, 2023 · 1 comment · Fixed by #418
Closed

NotImplementedError in TestLaserSpectrum unit test #417

vsnever opened this issue Aug 9, 2023 · 1 comment · Fixed by #418
Assignees
@vsnever
Labels
bug

Comments

@vsnever
Copy link
Member

vsnever commented Aug 9, 2023

The TestLaserSpectrum unit test raises NotImplementedError with Cython 3.0 because the evaluate() method is not implemented in the base LaserSpectrum class. For some reason this exception was ignored with Cython 0.29.

I suggest doing the tests for the ConstantSpectrum as it is the simplest LaserSpectrum subclass that implements the evaluate() method.
@vsnever vsnever added the bug label Aug 9, 2023
@vsnever vsnever self-assigned this Aug 9, 2023
@vsnever vsnever mentioned this issue Aug 9, 2023
Merged
@vsnever vsnever linked a pull request Aug 9, 2023 that will close this issue
Fix NotImplementedError in the TestLaserSpectrum unit test. #418
Merged
@vsnever
Copy link
Member Author

vsnever commented Aug 9, 2023

Fixed in #418.

@vsnever vsnever closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsnever vsnever

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NotImplementedError in the TestLaserSpectrum unit test. vsnever/cherab-core
1 participant
@vsnever