Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NotImplementedError in the TestLaserSpectrum unit test. #418

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix NotImplementedError in the TestLaserSpectrum unit test. #418

merged 1 commit into from
Aug 9, 2023

Conversation

vsnever
Copy link
Member

@vsnever vsnever commented Aug 9, 2023

This fixes #417 by replacing the base TestLaserSpectrum with its simplest subclass ConstantSpectrum. It also fixes the test for the bins property.

@vsnever vsnever requested a review from Mateasek August 9, 2023 10:05
@vsnever vsnever linked an issue Aug 9, 2023 that may be closed by this pull request
NotImplementedError in TestLaserSpectrum unit test #417
Closed
Mateasek
Mateasek approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@Mateasek Mateasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it @vsnever . I didn't run the tests myself, but the code seems ok to me.

@vsnever
Copy link
Member Author

vsnever commented Aug 9, 2023

CI tests failed on Python 3.10 because Raysect 0.8.1 does not have a wheel for 3.10 and is not compatible with Cython 3.0.

@vsnever
Copy link
Member Author

vsnever commented Aug 9, 2023

Thanks @Mateasek, I'll merge it then.

@vsnever vsnever merged commit 089d88a into cherab:development Aug 9, 2023
6 of 8 checks passed
@vsnever vsnever mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mateasek Mateasek Mateasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotImplementedError in TestLaserSpectrum unit test
2 participants
@vsnever @Mateasek