Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Move Plasma and Beam set up into the setUp() method #449

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Tests: Move Plasma and Beam set up into the setUp() method #449

merged 1 commit into from
Jul 31, 2024

Conversation

vsnever
Copy link
Member

@vsnever vsnever commented Jul 20, 2024

This fixes #448 by moving the creation and configuration of the Plasma and Beam to the setUp() method in the TestBeam, TestBeamCXLine, TestBremsstrahlung and TestLineShapes test cases.

@vsnever vsnever requested a review from jacklovell July 20, 2024 17:24
Mateasek
Mateasek approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Mateasek Mateasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvement @vsnever

@jacklovell jacklovell merged commit 18eacf6 into cherab:development Jul 31, 2024
8 checks passed
@vsnever vsnever mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mateasek Mateasek Mateasek approved these changes

@jacklovell jacklovell jacklovell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsnever @Mateasek @jacklovell