-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emission due to CX with neutral hydrogen to the TotalRadiatedPower model #455
Add emission due to CX with neutral hydrogen to the TotalRadiatedPower model #455
Conversation
…thermal neutral hydrogen to the TotalRadiatedPower model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vsnever , thanks for adding the CX radiated power. There are two points I would like you to look into and consider changes. Otherwise this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fof the improvement @vsnever , this can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: the documentation and test coverage is particularly welcome! Just a couple of small comments before merging.
…etter in TotalRadiatedPower.populate_cache().
Cherab atomic data repository support three types of total radiated power coefficients:
LineRadiationPower
,ContinuumPower
,CXRadiationPower
.However, only the first two coefficients are used in the
TotalRadiatedPower
model. Adding a third source of power loss does not seem difficult. Taking into account CX, the emissions calculated by this model will be as follows:where nhyd is the total density of all hydrogen isotopes in the plasma.
This PR adds CX radiated power for hydrogen donors to the
TotalRadiatedPower
model, thus fixing #370.Also, the
evaluate()
method of the_RadiatedPower
core class was defined ascdef
instead ofcpdef
. A changed it tocpdef
just like in other atomic rate classes, because withcdef
definition I could not createMockAtomicData
class for the unit test.