Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e_field attribute to Plasma object for electric field vector #466

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add e_field attribute to Plasma object for electric field vector #466

wants to merge 2 commits into from

Conversation

vsnever
Copy link
Member

@vsnever vsnever commented Aug 30, 2024

This PR implements #465 by introducing the e_field attribute to the Plasma object for the electric field vector function. This electric field will be used in the new BeamEmissionMultiplet model (#415) as an addition to the Lorentz field v⨉B.

jacklovell
jacklovell approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jacklovell jacklovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It would be nice to have a couple of simple unit tests to check setting and getting works (mainly useful for regression testing later on I expect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacklovell jacklovell jacklovell approved these changes

@Mateasek Mateasek Awaiting requested review from Mateasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsnever @jacklovell