Skip to content

Commit

Permalink
refactor: remove unused methods
Browse files Browse the repository at this point in the history
  • Loading branch information
kanru committed Dec 25, 2024
1 parent 45eeab0 commit 882096b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
10 changes: 1 addition & 9 deletions chewing_tip/ChewingTextService.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ TextService::TextService():
// add language bar buttons
// siwtch Chinese/English modes
TF_LANGBARITEMINFO info = {
clsid(),
g_textServiceClsid,
g_modeButtonGuid,
TF_LBI_STYLE_BTN_BUTTON,
0,
Expand Down Expand Up @@ -183,10 +183,6 @@ TextService::~TextService(void) {
freeChewingContext();
}

CLSID TextService::clsid() {
return g_textServiceClsid;
}

// virtual
void TextService::onActivate() {
config().reloadIfNeeded();
Expand All @@ -206,10 +202,6 @@ void TextService::onDeactivate() {
hideCandidates();
}

// virtual
void TextService::onFocus() {
}

// virtual
void TextService::onKillFocus() {
if (isComposing()) {
Expand Down
3 changes: 0 additions & 3 deletions chewing_tip/ChewingTextService.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,9 @@ class TextService:
TextService();
virtual ~TextService(void);

virtual CLSID clsid();

virtual void onActivate();
virtual void onDeactivate();

virtual void onFocus();
virtual void onKillFocus();

virtual bool filterKeyDown(Ime::KeyEvent& keyEvent);
Expand Down
2 changes: 0 additions & 2 deletions chewing_tip/TextService.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ class TextService:
void removeCompartmentMonitor(const GUID key);

// virtual functions that IME implementors may need to override
virtual CLSID clsid() = 0;

virtual void onActivate() {}
virtual void onDeactivate() {}

Expand Down

0 comments on commit 882096b

Please sign in to comment.