Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting charts from kw to mw #59

Merged
merged 2 commits into from
Jun 19, 2024
Merged

converting charts from kw to mw #59

merged 2 commits into from
Jun 19, 2024

Conversation

derekeder
Copy link
Member

Overview

Demo

Screenshot 2024-06-14 at 4 52 55 PM

Screenshot 2024-06-14 at 4 53 00 PM

Testing Instructions

  • compare the about page for this PR and the live site. the numbers in the table, pie chart and time series chart should be the same, just rounded to the nearest 1,000 (MW instead of KW)

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for il-solar-map ready!

Name Link
🔨 Latest commit ab27294
🔍 Latest deploy log https://app.netlify.com/sites/il-solar-map/deploys/6670635d040655000813431b
😎 Deploy Preview https://deploy-preview-59--il-solar-map.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@derekeder derekeder requested a review from vkoves June 14, 2024 21:58
@vkoves
Copy link
Collaborator

vkoves commented Jun 15, 2024

@derekeder - I know we also mentioned making clearer the about page graph legend is really a set of filters, either with a text label or better styling. Did you want to tackle that in this PR as well?

Update: Nevermind, I see that's issue #53

@vkoves
Copy link
Collaborator

vkoves commented Jun 15, 2024

I think the only note is under the graph there's a note that's still in kilowatts

Screenshot from 2024-06-15 14-28-51

Also do you want to also update the reference tables, or keep those the same since it's by county?

@derekeder
Copy link
Member Author

derekeder commented Jun 17, 2024

@vkoves thx - fixed the additional kilowatt references. I also updated the chart colors to match again across the pie and time series (utility is blue, community solar is orange, etc)

I think I'll keep the reference tables in kilowatts, but will add units and put in friendlier labels. I have an issue open for it #49

Copy link
Collaborator

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me now!

@derekeder derekeder merged commit 3eeaba5 into main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change time series chart order to show largest on the bottom show power generated in MW instead of KW
2 participants