libkkc #2022
Closed
libkkc #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekopsykose
reviewed
May 20, 2024
Comment on lines
+33
to
+45
| def post_install(self): | ||
| license_dir = f"usr/share/licenses/{pkgname}" | ||
| self.install_file("COPYING", f"{license_dir}/GPL-3.0") | ||
|
|
||
| with open("README.md") as f: | ||
| readme_lines = f.read().split("\n") | ||
| relevant_lines = readme_lines[60:-1] | ||
| assert relevant_lines[0] == "GPLv3+" | ||
| assert not any(lambda x: x == "```", relevant_lines) | ||
| with open("extra-license") as f: | ||
| for line in relevant_lines: | ||
| f.write(line + "\n") | ||
| self.install_file("extra-license", f"{license_dir}/custom") |
There was a problem hiding this comment.
you definitely dont need any of this
nekopsykose
reviewed
May 20, 2024
Comment on lines
+8
to
+10
| "autoconf", | ||
| "automake", | ||
| "clang", |
There was a problem hiding this comment.
Suggested change
| "autoconf", | |
| "automake", | |
| "clang", | |
| "automake", |
There was a problem hiding this comment.
well, just copy the version from #1957 for this, though i think i will add this myself for something else first
|
ah it was this; fixing that isnt too hard but this then fails in like 10 spots later because kkc is an ancient codebase and idk how to fix any of the other parts :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building fails with "ERROR: can't resolve libraries to shared libraries: m, atomic". Not sure what to do about that; manually depending on libatomic-chimera(-devel) doesn't help and IIUC libm is just part of libc under musl.