Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/pipewire: enable roc support #2987

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Sep 23, 2024

probably should figure out the really annoying noise (according to psykose udp has a lot of noise with musl's memcpyi was trolled)

@nekopsykose
Copy link
Member

(according to psykose udp has a lot of noise with musl's memcpy)

this was an audiophile shitpost lmao, haha

@@ -9,7 +9,6 @@
"-Dsdl2=disabled", # examples
"-Dsystemd=disabled",
"-Dlibffado=disabled",
"-Droc=disabled", # TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should prolly split the module and the libs below and then install_if = parent, roc-toolkit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good now

@triallax
Copy link
Contributor Author

@nekopsykose classic

@triallax
Copy link
Contributor Author

i do still need to figure out the noise though

_scons_flags = [
"--disable-openfec",
"--disable-sox",
"--disable-alsa",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what setup do you use that you get crackling in? is it pipewire on both sides using the plugins, or is one side using roc-send/recv?

if you're using the cli utils on either side then you might actually want to have alsa enabled so they are directly outputting and not going through an extra layer, or at least that's a guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sender is chimera linux with pipewire-roc, the receiver is android using roc droid, so i think what you're suggesting doesn't apply

@triallax triallax marked this pull request as draft October 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants