Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/python-tzdata: update to 2024.2 #3006

Closed
wants to merge 1 commit into from

Conversation

ttyyls
Copy link
Contributor

@ttyyls ttyyls commented Sep 25, 2024

No description provided.

@triallax
Copy link
Contributor

thank you for the pr, but i'm wondering why this package exists in the first place? according to https://github.com/python/tzdata?tab=readme-ov-file#tzdata-python-package-providing-iana-time-zone-data:

It is intended to be a fallback for systems that do not have system time zone data installed (or don't have it installed in a standard location)

i checked our python's configure process and here it is:

checking for --with-tzpath... "/usr/share/zoneinfo:/usr/lib/zoneinfo:/usr/share/lib/zoneinfo:/etc/zoneinfo"

(our tzdata is at /usr/share/zoneinfo)

so installing tzdata instead of python-tzdata (which is just a redistribution of the tzdata database) both allow python programs to access timezone data just fine, so unless i'm missing something this package isn't necessary

(though this isn't directly relevant to this pr, it might make sense to add tzdata as a runtime dep of python? it's not a hard dependency however so unsure about it)

@nekopsykose
Copy link
Member

nekopsykose commented Sep 26, 2024

i thought it might've existed to at least make the 'something does import tzdata' case work without a patch (the only thing exported is the version number, there's no api), but no, this has never been used by anything

@ttyyls
Copy link
Contributor Author

ttyyls commented Sep 26, 2024

it was a check dependency of python-jsonickle which was brought by python-pandas which was a dependency of certbot, another maintainer rebased out that dep by skipping the pandas test thus dropping pandas but not its leaf dep: python-tzdata.

This should've never made it in to begin with, drop it at your convenience.

@ttyyls ttyyls closed this Sep 26, 2024
triallax added a commit that referenced this pull request Sep 26, 2024
see #3006 (comment)
TL;DR python uses system tzdata, and falls back to this package
otherwise, and since we of course have tzdata packaged there's no reason
to have this around
@triallax
Copy link
Contributor

thank you, dropped in c06ef5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants