-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/binsider: new package #3032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekopsykose
reviewed
Oct 1, 2024
nekopsykose
reviewed
Oct 1, 2024
tulilirockz
force-pushed
the
user/binsider
branch
from
October 1, 2024 15:51
1509510
to
cd1445a
Compare
these tests just fail on CI but it works fine on my system... what.... |
sounds related to the tui it's in then |
considering the assert is in a tui crate |
yup. its definitely something with that. ill just ignore those tests |
just skip them all |
tulilirockz
force-pushed
the
user/binsider
branch
2 times, most recently
from
October 1, 2024 16:11
26967b0
to
c9343ac
Compare
nekopsykose
reviewed
Oct 1, 2024
I'd recommend running the tests via |
ah, sure, i guess that's easier |
tulilirockz
force-pushed
the
user/binsider
branch
from
October 1, 2024 16:31
c9343ac
to
e14935d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.