Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/binsider: new package #3032

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

tulilirockz
Copy link
Contributor

No description provided.

@tulilirockz
Copy link
Contributor Author

these tests just fail on CI but it works fine on my system... what....

@nekopsykose
Copy link
Member

sounds related to the tui it's in then

@nekopsykose
Copy link
Member

considering the assert is in a tui crate

@tulilirockz
Copy link
Contributor Author

running 5 tests
test tui::ui::tests::test_highlight_search_line ... ignored
test error::tests::test_error ... ok
test tui::ui::tests::test_highlight_search_string ... ok
test tui::widgets::list::tests::test_selectable_list ... ok
test args::tests::test_args ... ok

test result: ok. 4 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/x86_64-chimera-linux-musl/debug/deps/binsider-79faa2dd7a0d7864)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/app.rs (target/x86_64-chimera-linux-musl/debug/deps/app-fd588a93bf6e127e)

running 2 tests
test test_init ... ok

test test_extract_strings ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 17.23s

   Doc-tests binsider

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

yup. its definitely something with that. ill just ignore those tests

@nekopsykose
Copy link
Member

just skip them all

@tulilirockz tulilirockz force-pushed the user/binsider branch 2 times, most recently from 26967b0 to c9343ac Compare October 1, 2024 16:11
@orhun
Copy link

orhun commented Oct 1, 2024

I'd recommend running the tests via cargo test --lib (or disabling them) until we have a better test suite. See: orhun/binsider#5

@nekopsykose
Copy link
Member

ah, sure, i guess that's easier

@nekopsykose nekopsykose merged commit 5d876d4 into chimera-linux:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants