Parse \/ correctly when input json #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
darthbear
reviewed
Feb 12, 2023
| @@ -239,6 +239,7 @@ class ConfigParser(object): | |||
| '\\#': '#', | |||
| '\\!': '!', | |||
| '\\"': '"', | |||
| '\/': '/', | |||
There was a problem hiding this comment.
Should it be \\/ instead? Do you have an example where you use it?
There was a problem hiding this comment.
As shown in #293 , json use \/ in unix path string like {"path":"\/var"}.
pyhocon does not parse it correctly as jq does.
# echo '{"path":"\/var"}' | jq .
{
"path": "/var"
}
# echo '{"path":"\/var"}' | pyhocon
{
"path": "\\/var"
}There was a problem hiding this comment.
Python handles \ in a strange way. '\/', '\\/', "\/" and "\\/" all work.
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print('\/')
\/
>>> print("\/")
\/
>>> print("\\/")
\/
>>> print('\\/')
\/
>>> '\/var'.replace('\/','/')
'/var'
>>> '\/var'.replace('\\/','/')
'/var'
>>> '\/var'.replace("\/",'/')
'/var'
>>> '\/var'.replace("\\/",'/')
'/var'
There was a problem hiding this comment.
This syntax is described in RFC 8259 Section 7 Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#293
It seems not difficult to fix. But don' know side effect.