Features/team resources endpoints

[curtwl]

Description

Create endpoints for team resources

Issue link

Fixes # 18

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Tested with Swagger and Postman.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[cherylli]

you can run yarn format to fix lint errors

[jenny-alexander]

LGTM - great job taking in all comments and incorporating them into your code.
I tested endpoints locally.
Endpoints should be plural - we will take care of that in another task

Wrong PR!

[jenny-alexander]

Reviewed changes - looks good.
I tested 2 more random API endpoints within team resources to make sure they work as expected.

Only outstanding is the userId within body of resource DTO - will this be removed once auth is in?

[Dan-Y-Ko]

Reviewed changes - looks good. I tested 2 more random API endpoints within team resources to make sure they work as expected.

Only outstanding is the userId within body of resource DTO - will this be removed once auth is in?

That's correct.

I haven't looked into this in detail but I think it'd be good to name the folder voyage resources or something like that since we have this resources and the global resources. Idk what naming convention be team decided on but it looks like there's another folder using kebab casing, so voyage-resources? Something like that.

[cherylli]

Reviewed changes - looks good. I tested 2 more random API endpoints within team resources to make sure they work as expected.
Only outstanding is the userId within body of resource DTO - will this be removed once auth is in?

That's correct.

I haven't looked into this in detail but I think it'd be good to name the folder voyage resources or something like that since we have this resources and the global resources. Idk what naming convention be team decided on but it looks like there's another folder using kebab casing, so voyage-resources? Something like that.

yes nestjs use kebab case for files and folders

outdated

[cherylli]

I see you are solely using teamMemberId, in this case, userId won't be required at all. But I've explained why I believe using userId + team Id to find teamMemberId in the backend would be better in another comment

[jenny-alexander]

LGTM

[jenny-alexander]

Changed approved

[smurph7894]

Tested each of the endpoints and they are working an protect for creator only edits when required.

[smurph7894]

Do we want to consider having a validator that a url is bring input? It looks like prisma does work with regex and other options. https://www.prisma.io/docs/concepts/components/prisma-client/custom-validation

[cherylli]

Do we want to consider having a validator that a url is bring input? It looks like prisma does work with regex and other options. https://www.prisma.io/docs/concepts/components/prisma-client/custom-validation

nestjs has a @IsUrl

[cherylli]

Looks good but missing some basic error handling for the POST and GET, like if TeamId doesn't exist it just returns a generic 500 error.

I also agree to adding something to validate it's a url, you could look at nestjs built in @IsUrl

and for GET, if the team doesn't exist it returns [] which should probably return an error, as opposed to returning [] when there's actually no votes

[kennytram]

lgtm

We can always add error-handling in later especially when other api controllers will also need error-handling.