Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI flash stack spec draft #18

Merged
merged 7 commits into from
Nov 18, 2024
Merged

SPI flash stack spec draft #18

merged 7 commits into from
Nov 18, 2024

Conversation

helloxiling
Copy link
Collaborator

No description provided.

@helloxiling helloxiling marked this pull request as ready for review November 16, 2024 02:29
@helloxiling helloxiling changed the title Draft: SPI flash stack spec SPI flash stack spec Nov 16, 2024
@helloxiling helloxiling changed the title SPI flash stack spec SPI flash stack spec draft Nov 16, 2024
Copy link
Collaborator

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

We don't need all of the 'a annotations in the Rust code -- I don't think they're important for the documentation.

Copy link
Collaborator

@mlvisaya mlvisaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/spi.md Outdated
- **Flash partition capsule interface**:

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we combine SpiFlashCapsule, VirtualSpiMaster, MuxSpiMaster and SPI Host Driver into a flash controller

@helloxiling helloxiling merged commit 392b666 into main Nov 18, 2024
1 check passed
@helloxiling helloxiling deleted the xsun/spi_design_spec branch December 16, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants