User space interface for DMA and Mailbox #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlvisaya
force-pushed
the
mlvisaya/image-loading
branch
2 times, most recently
from
60b23bd to
edc2136
Compare
mlvisaya
requested review from
swenson,
parvathib,
mhatrevi,
vsonims and
helloxiling
swenson
reviewed
Jan 3, 2025
mlvisaya
force-pushed
the
mlvisaya/image-loading
branch
from
a3bc7ce to
60ddd87
Compare
Added user APIs for DMA and mailbox The DMA API allows for AXI-to-AXI transfers or from local buffer to an AXI component. The Mailbox API allows for executing a mailbox command in an atomic fashion, i.e. execute command, wait for response, return response.
mlvisaya
force-pushed
the
mlvisaya/image-loading
branch
from
521d58b to
808c333
Compare
Use TockSubscribe while passing buffers with the required permission Add tock API to pass ro and rw buffers for the mailbox use case
|
@helloxiling , thanks I updated this PR now to be consistent with Flash and MCTP implementations |
swenson
reviewed
Jan 9, 2025
runtime/apps/syscall/src/dma.rs
Outdated
| #[derive(Debug, Clone)] | ||
| pub enum DMASource<'a> { | ||
| /// A memory address as the source. | ||
| Address(u64), |
There was a problem hiding this comment.
Is this an AXI address or a local memory address (which would be a u32)?
It might be good to have a separate type for AXI addresses so that we don't mix them up. Something like pub type AxiAddr(u64); or pub type AxiAddr = u64.
There was a problem hiding this comment.
it is Axi address. good point, I can create a new type for AxiAddr
Define AXIAddr type Remove unnecessary async keyword
…e syscall interface
helloxiling
approved these changes
Jan 10, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.