Refactor memory_layout and persistent_data #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
mhatrevi,
ajisaxena,
vsonims,
korran,
JohnTraverAmd,
rusty1968 and
swenson
as code owners
jhand2
previously approved these changes
Oct 18, 2024
This was referenced Oct 23, 2024
clundin25
force-pushed
the
rom-layout
branch
2 times, most recently
from
eab13ff to
8a54c60
Compare
clundin25
force-pushed
the
rom-layout
branch
from
8a54c60 to
ec890e6
Compare
clundin25
changed the title
clundin25
force-pushed
the
rom-layout
branch
from
ec890e6 to
0792abb
Compare
jhand2
reviewed
Dec 2, 2024
jhand2
previously approved these changes
Dec 2, 2024
jhand2
previously approved these changes
Dec 2, 2024
clundin25
force-pushed
the
rom-layout
branch
from
4414cff to
ba6588c
Compare
mhatrevi
reviewed
Dec 17, 2024
mhatrevi
reviewed
Dec 17, 2024
mhatrevi
reviewed
Dec 17, 2024
mhatrevi
requested changes
Dec 17, 2024
clundin25
force-pushed
the
rom-layout
branch
from
ba6588c to
0a96db2
Compare
clundin25
force-pushed
the
rom-layout
branch
2 times, most recently
from
1c7e3dd to
8a057b4
Compare
* Reserve a portion of DCCM for future changes to PersistentData. * Remove most hard coded addresses in memory layout. * Reserved 19KiB in `PersistentData`. * Left 8K in the Data section. Currently less than 4KiB is being used. This resolves chipsalliance#1662.
clundin25
force-pushed
the
rom-layout
branch
from
8a057b4 to
4b550af
Compare
mhatrevi
approved these changes
Dec 19, 2024
jhand2
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1662.