Add Axi bus behind the DMA engine #1878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I3C needs to be handled differently as it's on a separate bus. adamsbridge is now integrated inside the main RTL. It looks like uart was dropped too. Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
ajisaxena,
JohnTraverAmd and
rusty1968
as code owners
There was confusion on how that the dma engine operated on a axi bus that replaced the apb bus. This is not true. AXI is a completely separate bus and the DMA widget is a bridge to it. Signed-off-by: Arthur Heymans <[email protected]>
DMA operates on a separate bus and not the root bus so remove it. Signed-off-by: Arthur Heymans <[email protected]>
Copy most parts of the regular root bus. Changes: - Different type for address and data - No poll_fn, reset_fn Signed-off-by: Arthur Heymans <[email protected]>
Signed-off-by: Arthur Heymans <[email protected]>
This also adds the offset in the soc_ifc registers. Signed-off-by: Arthur Heymans <[email protected]>
korran
reviewed
Jan 6, 2025
|
|
||
| /// Represents an abstract AXI memory bus. Used to read and write from RAM and | ||
| /// peripheral addresses. | ||
| pub trait AxiBus { |
There was a problem hiding this comment.
I absolutely hate this copy-paste. Why didn't we just increase the address size to 64-bit everywhere?
There was a problem hiding this comment.
(assuming the only reason for this change is the increased word size): my preference:
- Use 64-bit addresses and data in Bus trait everywhere; the 32-bit parts could ignore the high bits and error when size is 64-bit.
- If that's not workable for some reason we could add associated types to the existing bus trait:
trait Bus {
type Addr: num_traits::PrimInt + num_traits::Unsigned + From<u32>;
type Data: num_traits::PrimInt + num_traits::Unsigned + From<u32>;
fn read(&mut self, addr: Self::Addr) -> Result<Self::Data, ()>;
// ...
}There was a problem hiding this comment.
poll and reset() could be moved to their own separate trait if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the DMA engine to operate on the Axi bus which is a 64bit bus.
The recovery register interface is placed on that bus.
An Axi address offset is placed in soc_ifc.