[nix] clean up impure env #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avimitin
added a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Oct 26, 2024
See chipsalliance/t1#817. Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
trivial-clean-up
branch
from
b8cd1b3 to
eaf1c3f
Compare
Avimitin
added a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Oct 26, 2024
See chipsalliance/t1#817. Signed-off-by: Avimitin <[email protected]>
Yesterday I reviewed my nix code and found that this ugly part can be immediately improved. These env should not have top level binding and evaluate with empty value everytime if "--impure" does not supply. There should be value bind to them when they get evaluated, or they should never exist in our nixpkgs namespace. Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
trivial-clean-up
branch
from
eaf1c3f to
9de784b
Compare
Avimitin
added a commit
to chipsalliance/chisel-nix
that referenced
this pull request
Oct 26, 2024
See chipsalliance/t1#817. Signed-off-by: Avimitin <[email protected]>
|
wat? why the performance got improved in this PR. |
|
Seems the last CI report workflow was skip due to external repository issue. So the performance improvement doesn't get recorded. https://github.com/chipsalliance/t1/actions/runs/11477882170/job/31941451053 not a big deal, ok to merge this pr. |
sequencer
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I reviewed my nix code and found that this ugly part can be immediately improved. These env should not have top level binding and evaluate with empty value everytime if "--impure" does not supply. There should be value bind to them when they get evaluated, or they should never exist in our nixpkgs namespace.