Fix icons/src property so that it does not 404 #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign off on your commits. |
|
I am adhering to the Developer Certificate of Origin. |
|
Your commits must be signed. |
Signed-off-by: digitalbricklayer <[email protected]>
digitalbricklayer
force-pushed
the
master
branch
from
0cf7537 to
fb2b119
Compare
|
Can confirm change is now signed-off. |
onweru
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the icons in site.webmanifest pointing to the wrong location. The src property points to the root of the site instead of the icons directory.
Pull Request type
Please check the type of change your PR introduces:
Current state
Closes #458
Proposed changes
Changes the icon src to be relative to the icons folder. According to the site.webmanifest spec, if you specify a relative link, it assumes that the link is relative to the location of the site.webmanifest file itself.
Screenshots, if applicable
Checklist
git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.I am adhering to the Developer Certificate of Origin.