Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onhover link icon color in dark mode #479

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

barefootstache
Copy link
Contributor

fix: onhover link icon color in dark mode from the existing black to white.

Cannot use the existing system, since the link.svg icon is being imported as an image, thus one needs to use the filter property in CSS.

@chipzoller chipzoller merged commit 174847b into chipzoller:master Sep 16, 2024
3 checks passed
@chipzoller
Copy link
Owner

Thanks for the contribution!

@gefloh
Copy link

gefloh commented Nov 17, 2024

@barefootstache @chipzoller Hm for me this destroys the colors of the icon in the footer, left of the copyright in dark mode. In the example site this looks ok, but if you use a more sophisticated icon with more colors, this is not good.

@chipzoller
Copy link
Owner

Can you provide an example?

@gefloh
Copy link

gefloh commented Nov 17, 2024

Before:
grafik

Now:
grafik

@barefootstache
Copy link
Contributor Author

If this is the only place, then we could prepend

body > :not(footer)

into the variables to catch the case with the icon in the footer to stay static between dark/light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants