[android] Fix attachments and add option to set custom label for chooser #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I'd just like to endorse this PR. I made equivalent changes locally before noticing that this covered the same ground. As the PR author states, common mail apps like Google Inbox and Microsoft Outlook for Android don't understand ACTION_SENDTO when used with attachments. Android's documented guidance is to use ACTION_SEND in this scenario instead: https://developer.android.com/guide/components/intents-common.html#Email Finally, being able to supply a title string from your localised JavaScript code string tables is also great. |
nmorel
pushed a commit
to Mille-Volts/react-native-mail
that referenced
this pull request
Feb 21, 2017
Merged PR chirag04#42
|
@chirag04 Is it possible to merge this PR? This would also be very helpful to us. |
|
Can you rebase? |
nmorel
pushed a commit
to Mille-Volts/react-native-mail
that referenced
this pull request
Dec 18, 2017
Merged PR chirag04#42 (cherry picked from commit 563d90a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending mail with attachment correct action is
ACTION_SEND, with current solution many email clients are ignroing the attachment. Also I've addedchooserLabeloption so people can specify their own title for chooser (localized etc..). Both changes have been tested on device and I am successfuly using it in my application.