(#747) Switch CryptoHashProvider to filestream for hashing files #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
changed the title
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
3cb7d53
to
4f242ef
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
2 times, most recently
from
29ba825
to
b3a8f3c
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
b3a8f3c
to
0123c01
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
0123c01
to
baba7a2
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
2 times, most recently
from
934448d
to
ed87cd9
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
ed87cd9
to
1092b6c
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
1092b6c
to
3292e4b
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
3292e4b
to
1153a97
Compare
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
1153a97
to
063d92e
Compare
6 tasks
…files Previously, when getting the checksum of a file, this read the file into a byte array to pass to ComputeHash. However, this was limited to files of 2gb or less, and was not efficent memory wise. This changes the method to using a filestream which is passed to ComputeHash, which should allow arbitrary file sizes with better memory usage. The unit test for this method had to be removed because the mock filesystem does not allow opening a file stream.
TheCakeIsNaOH
force-pushed
the
stream-hashes
branch
from
063d92e
to
bda2cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This changes the
hash_filemethod to use a filestream which is passed to ComputeHash, whichshould allow arbitrary file sizes with better memory usage.
The unit test for this method had to be removed because the mock
filesystem does not allow opening a file stream.
Motivation and Context
Previously, when getting the checksum of a file, this read the file
into a byte array to pass to ComputeHash. However, this was limited to
files of 2gb or less, and was not efficent memory wise.
Testing
Ran integration and units tests.
Validated that the warning/error about the file being too large was resolved this way:
.nupkgover 2gb.\choco.exe install davinci-resolve -s . --verbose --debug --skippowershell.chocolatey\davinci-resolve\.filesand validated that the.nupkghad the correct md5 checksum recorded.Change Types Made
Related Issue
Fixes #747
Change Checklist