Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1031) Update wording of custom install location #1054

Merged
merged 4 commits into from
Sep 6, 2024
Merged

(#1031) Update wording of custom install location #1054

merged 4 commits into from
Sep 6, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Sep 3, 2024

Description Of Changes

Updates the wording of the custom install location documents to clarify that the ChocolateyInstall variable must be available to the process that is installing Chocolatey.

Motivation and Context

The previous wording was ambiguous.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

@corbob
(chocolatey#1031) Update wording of custom install location
1f68ffe 
Updates the wording of the custom install location documents to clarify
that the ChocolateyInstall variable must be available to the process
that is installing Chocolatey.
pauby
pauby requested changes Sep 4, 2024
View reviewed changes
src/content/docs/en-us/choco/setup.mdx Outdated Show resolved Hide resolved
@corbob
(maint) Update gitignore for build artifacts
dc91cd0
@corbob
(maint) Enable the code spell extension for MDX
2783e5b 
By default the MDX files are not spell checked with code spell checker.
This updates the settings to enable spell check of these files.
@corbob
(chocolatey#1031) Update wording for setting variable
1b37b82 
Updates the wording to give a few options for setting the environment
variable. Adds information for how to verify it has been set.
@pauby pauby merged commit 7d37b7a into chocolatey:master Sep 6, 2024
1 check passed
@pauby
Copy link
Member

pauby commented Sep 6, 2024

Thanks for adding those changes @corbob!

@corbob corbob deleted the custom-directory branch September 6, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the non-default installation directory documentation to clarify the environment variable
2 participants
@corbob @pauby