Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) ID cannot contain the word chocolatey #760

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

pauby
Copy link
Member

@pauby pauby commented Jun 24, 2023

Description Of Changes

Adding a note to confirm that package ID's cannot contain the word chocolatey.

Motivation and Context

A package with the name chocolatey may give the impression that it is official and supported. While this is known, it's not documented.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

N/A

@pauby pauby requested a review from gep13 June 25, 2023 13:45
JPRuskin
JPRuskin previously approved these changes Jun 26, 2023
Copy link
Member

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised we'd leave choco- available - it also feels pretty "official"... This is a sensible change, though.

@pauby
Copy link
Member Author

pauby commented Jun 26, 2023

We do require the title to day 'Unofficial' if choco is used. Maybe I should add that here too?

@gep13
Copy link
Member

gep13 commented Jun 26, 2023

@pauby said...
Maybe I should add that here too?

Yes, I think that this would be a good addition as well.

@pauby
Copy link
Member Author

pauby commented Jun 26, 2023

@JPRuskin @gep13 I've added that now so this is ready for another review.

Copy link
Member

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JPRuskin JPRuskin merged commit 84f9415 into chocolatey:master Jun 26, 2023
choco-bot pushed a commit that referenced this pull request Jun 26, 2023
Merge pull request #760 from pauby/doc/add-id-not-chocolatey-name

(doc)  ID cannot contain the word chocolatey
@pauby pauby deleted the doc/add-id-not-chocolatey-name branch June 1, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants