Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy documentation #765

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Update proxy documentation #765

merged 3 commits into from
Jul 14, 2023

Conversation

corbob
Copy link
Member

@corbob corbob commented Jun 28, 2023

Description Of Changes

Update the proxy documentation to be clear about the order of proxy configurations applying. Add known issues with links.

Motivation and Context

The proxy configuration has changed slightly from Chocolatey CLI 1.4 to 2.1.0

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

  • ENGTASKS-3200

@corbob corbob requested a review from pauby June 28, 2023 23:32
@corbob corbob force-pushed the proxy-docs branch 2 times, most recently from cfb4a2a to a6d8d4d Compare June 29, 2023 16:59
"Title Case" the section headers. Add punctuation to the end of all list
items.
@corbob
Copy link
Member Author

corbob commented Jul 14, 2023

I've updated the docs with the requested changes from pauby. I have included them as a fixup! commit with the intention that we should git rebase upstream/master -i --autosquash before the merge which will bring the branch in line with master, as well as fixup the mentioned commit into the original commit where the changes were made.

Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for fixing this up! 💖

Add information about the precedence order of Proxy configurations. Add
information about known limitations to the proxy settings.
@vexx32 vexx32 dismissed pauby’s stale review July 14, 2023 19:18

requested changes have been applied

@vexx32 vexx32 merged commit f40ffce into chocolatey:master Jul 14, 2023
choco-bot pushed a commit that referenced this pull request Jul 14, 2023
Merge pull request #765 from corbob/proxy-docs

Update proxy documentation
@corbob corbob deleted the proxy-docs branch July 14, 2023 19:48
corbob added a commit to corbob/docs that referenced this pull request Jul 17, 2023
pauby added a commit that referenced this pull request Jul 18, 2023
Revert header formatting changes from #765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants