Remove randomness by default of BBox strategies #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be random)+ code cleanup
ArthurGodet
approved these changes
Oct 21, 2023
|
I think we should revert the PR and wait for the checks to pass. |
|
Yes, I do agree that we should revert the PR until the tests have been updated. It seems that the 5 failing tests are all based on testing the number of solutions encountered during the search (which is not surprising that they might fail with the new code that break ties). |
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to define how ties are broken in black-box strategies.
Previously, ties were broken randomly, which is a kind of admission of powerlessness.
I propose, with this PR, to make possible to declare a tie-breaker if needed or let the default one which is based on lexical ordering (=variables input order).
Note that this change has few mainly an impact on fresh start when no score are recorded, but as it drives the search to different search space, it may have a huge impact (+ or -) on efficiency.
However, now, we can tweak it.