Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Retrospective" tab to dashboard #121

Merged
merged 34 commits into from
Jun 15, 2021
Merged

Add "Retrospective" tab to dashboard #121

merged 34 commits into from
Jun 15, 2021

Conversation

glass-w
Copy link
Contributor

@glass-w glass-w commented Dec 14, 2020

Description

Starts to address point (1) in #108

Todos

  • create new tab with compounds that contain experimental pIC50 data.
  • add master plot with: the relative free energies between pairs of compounds with experimental data available vs. predicted transformation free energies between them (if available).
  • check values plotted and reported are correct (as well as methodology).

Status

  • Ready to go

@glass-w
Copy link
Contributor Author

glass-w commented Dec 18, 2020

last commit fixes #123

@glass-w glass-w self-assigned this Dec 18, 2020
@glass-w glass-w marked this pull request as ready for review January 11, 2021 14:26
@glass-w glass-w requested a review from jchodera January 11, 2021 14:26
@glass-w
Copy link
Contributor Author

glass-w commented Jan 11, 2021

An example of how this retrsopective tab looks can be found here

@jchodera
Copy link
Member

Looks like there's an import plotly somewhere now:

  File "/home/server/miniconda/envs/fah-xchem-staging/bin/fah-xchem", line 33, in <module>                                                                                                                                            [82/1981]
    sys.exit(load_entry_point('fah-xchem==0.1.0+64.g54f1a8f.dirty', 'console_scripts', 'fah-xchem')())                                                                                                                                         
  File "/home/server/miniconda/envs/fah-xchem-staging/bin/fah-xchem", line 25, in importlib_load_entry_point           
    return next(matches).load()                                                                                                                                                                                                                
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 93, in load                                                                                                            
    module = import_module(match.group('module'))                                                                                                                                                                                              
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/importlib/__init__.py", line 127, in import_module                                                                                                                         
    return _bootstrap._gcd_import(name[level:], package, level)                                                                                                                                                                                
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import                                                      
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load                                                                                                                                                                            
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked                                           
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked                                                                                                                                                                            
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module                                              
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed                                                                                                                                                                 
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/fah_xchem-0.1.0+64.g54f1a8f.dirty-py3.7.egg/fah_xchem/app.py", line 11, in <module>                                                                          
    from .analysis import analyze_compound_series                                                                      
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/fah_xchem-0.1.0+64.g54f1a8f.dirty-py3.7.egg/fah_xchem/analysis/__init__.py", line 32, in <module>                                                            
    from .plots import generate_plots                                                                                  
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/fah_xchem-0.1.0+64.g54f1a8f.dirty-py3.7.egg/fah_xchem/analysis/plots.py", line 23, in <module>                                                               
    from arsenic import plotting                                                                                       
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/arsenic/plotting.py", line 3, in <module>                                                                                                                    
    from arsenic import stats, plotlying                                                                               
  File "/home/server/miniconda/envs/fah-xchem-staging/lib/python3.7/site-packages/arsenic/plotlying.py", line 3, in <module>                                                                                                                   
    import plotly.graph_objects as go                                                                                  
ModuleNotFoundError: No module named 'plotly'  

@glass-w
Copy link
Contributor Author

glass-w commented Jan 12, 2021

@jchodera I've added the plotly dependency but I think all of the Arsenic packages should be handled when running pip install here. All of the required packages are in the Arsenic yaml file here so it should work without having to install plotly etc separately or adding it to the fah-xchem yaml.

@dotsdl
Copy link
Member

dotsdl commented Jun 10, 2021

Reviewing this now @glass-w! This is currently the branch being used in production, so would like to get this merged before anything else.

@glass-w
Copy link
Contributor Author

glass-w commented Jun 14, 2021

@dotsdl ok! Let me know if there is anything you'd like me to explain.

Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @glass-w! Can I get clarification on the questions below? Then we'll merge!

fah_xchem/analysis/website/__init__.py Outdated Show resolved Hide resolved
fah_xchem/analysis/__init__.py Outdated Show resolved Hide resolved
fah_xchem/analysis/__init__.py Outdated Show resolved Hide resolved
fah_xchem/analysis/__init__.py Show resolved Hide resolved
@dotsdl dotsdl changed the base branch from sprint-5 to master June 15, 2021 21:54
@dotsdl dotsdl merged commit 81e3639 into master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants