Skip to content

Commit

Permalink
fix versioning and add choral-standalone to the dist zip
Browse files Browse the repository at this point in the history
  • Loading branch information
fmontesi committed Aug 20, 2024
1 parent 1a48849 commit a7cb60a
Show file tree
Hide file tree
Showing 9 changed files with 142 additions and 133 deletions.
2 changes: 1 addition & 1 deletion base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
Expand Down
2 changes: 1 addition & 1 deletion choral-unit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
Expand Down
2 changes: 1 addition & 1 deletion choral/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
Expand Down
2 changes: 1 addition & 1 deletion compare/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
Expand Down
91 changes: 49 additions & 42 deletions dist/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,53 +5,60 @@ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assemb
<id>dist-assembly</id>

<formats>
<format>zip</format>
<format>zip</format>
</formats>
<fileSets>
<fileSet>
<directory>../choral/target</directory>
<includes>
<include>choral-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../base/target</directory>
<includes>
<include>base-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../choral-unit/target</directory>
<includes>
<include>choral-unit-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../runtime/target</directory>
<includes>
<include>runtime-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../scripts</directory>
<includes>
<include>choral</include>
</includes>
<outputDirectory>choral/launchers</outputDirectory>
</fileSet>
</fileSets>
<fileSet>
<directory>../choral/target</directory>
<includes>
<include>choral-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../base/target</directory>
<includes>
<include>base-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../choral-unit/target</directory>
<includes>
<include>choral-unit-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../runtime/target</directory>
<includes>
<include>runtime-${choral.version}.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>target</directory>
<includes>
<include>choral-standalone.jar</include>
</includes>
<outputDirectory>choral/dist</outputDirectory>
</fileSet>
<fileSet>
<directory>../scripts</directory>
<includes>
<include>choral</include>
</includes>
<outputDirectory>choral/launchers</outputDirectory>
</fileSet>
</fileSets>

<includeBaseDirectory>false</includeBaseDirectory>

<!--<dependencySets>
<dependencySet>
<outputDirectory>choral/dist</outputDirectory>
<useProjectArtifact>false</useProjectArtifact>
<unpack>false</unpack>
</dependencySet>
<dependencySet>
<outputDirectory>choral/dist</outputDirectory>
<useProjectArtifact>false</useProjectArtifact>
<unpack>false</unpack>
</dependencySet>
</dependencySets>-->
</assembly>
168 changes: 85 additions & 83 deletions dist/pom.xml
Original file line number Diff line number Diff line change
@@ -1,91 +1,93 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
<artifactId>Choral-zip</artifactId>
<version>0.1.2</version>
<artifactId>choral-zip</artifactId>
<url>${choral.url}</url>
<packaging>pom</packaging>

<properties>
<choral.version>0.1.2</choral.version>
<choral.url>https://www.choral-lang.org/</choral.url>
</properties>
<!-- add zip with all the jars from the submodules -->
<dependencies>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>base</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>choral</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>choral-unit</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>compare</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>runtime</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
</dependencies>

<!-- add zip with all the jars from the submodules -->
<dependencies>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>base</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>choral</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>choral-unit</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>compare</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.choral-lang</groupId>
<artifactId>runtime</artifactId>
<version>${choral.version}</version>
<type>jar</type>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>make-bundles</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<descriptors>
<descriptor>assembly.xml</descriptor>
</descriptors>
<finalName>choral-${choral.version}</finalName>
<appendAssemblyId>false</appendAssemblyId>
</configuration>
</execution>
<execution>
<id>make-uberjar</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
<archive>
<manifest>
<mainClass>choral.Choral</mainClass>
</manifest>
</archive>
<!-- <finalName>choral-v${choral.version}-standalone</finalName> -->
<finalName>choral-standalone</finalName>
<appendAssemblyId>false</appendAssemblyId>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
<build>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>make-bundles</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<descriptors>
<descriptor>assembly.xml</descriptor>
</descriptors>
<finalName>choral-${choral.version}</finalName>
<appendAssemblyId>false</appendAssemblyId>
</configuration>
</execution>
<execution>
<id>make-uberjar</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
<archive>
<manifest>
<mainClass>choral.Choral</mainClass>
</manifest>
</archive>
<!-- <finalName>choral-v${choral.version}-standalone</finalName> -->
<finalName>choral-standalone</finalName>
<appendAssemblyId>false</appendAssemblyId>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<version>0.1.2</version>
<version>1.0.0</version>
<packaging>pom</packaging>

<properties>
<choral.version>0.1.2</choral.version>
<choral.version>0.1.3</choral.version>
<choral.url>https://www.choral-lang.org/</choral.url>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
Expand Down
2 changes: 1 addition & 1 deletion runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<groupId>org.choral-lang</groupId>
Expand Down
2 changes: 1 addition & 1 deletion tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<groupId>org.choral-lang</groupId>
<artifactId>distribution</artifactId>
<relativePath>../pom.xml</relativePath>
<version>0.1.2</version>
<version>1.0.0</version>
</parent>
<version>${choral.version}</version>
<artifactId>tests</artifactId>
Expand Down

0 comments on commit a7cb60a

Please sign in to comment.