Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide basic openapi instances #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Provide basic openapi instances #23

wants to merge 4 commits into from

Conversation

worm2fed
Copy link

Initial issue was raised here: biocad/servant-openapi3#45

After some investigation I figured out, that to achieve this in proper way I need to make 3 PRs

  1. Add description to response headers biocad/servant-openapi3#48
  2. Use full header type in response header instances haskell-servant/servant#1697
  3. this one

NOTE: this PR (if accepted) must be merged at least after second one (to servant)

@worm2fed
Provide basic openapi instances
2f7f60a 
This is impossible to achieve this on client side, because response
headers defined in library.
@worm2fed
Add FromHttpApiData instances
18c1df0 
This is required to be able work with `servant-client`
ysangkok
ysangkok reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@ysangkok ysangkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a round trip test/

src/Servant/Pagination.hs Outdated Show resolved Hide resolved
@worm2fed
Copy link
Author

@ysangkok I'm stuck with ContentRange tests, there is restriction in type definition ToHttpApiData (RangeType resource field) which leads to error

• No instance for (ToHttpApiData
                         (RangeType Resource "fieldA 1..5"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysangkok ysangkok ysangkok left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worm2fed @ysangkok