Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2112) Ensure CHORIA_SRV_DOMAIN is actually getting used #2113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(#2112) Ensure CHORIA_SRV_DOMAIN is actually getting used #2113

wants to merge 1 commit into from
+8 −8

Commits on Feb 8, 2024

  1. (choria-io#2112) Ensure CHORIA_SRV_DOMAIN is actually getting used 

    The logic to pull config defaults from an environment variable is only used when a config has a default.
This adds empty string default for SRV domain which will trigger the logic to pull a default value also from the CHORIA_SRV_DOMAIN environment variable.
    @treydock
    treydock committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dccf403 View commit details
    Browse the repository at this point in the history