-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kitchen CI & Yum repos #1
Conversation
|
||
suites: | ||
- name: default | ||
run_list: | ||
- zabbix_ng::default | ||
#- zabbix_ng::sender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to either mark commented out blocks like this with a TODO
or simply remove them altogether. Similar like this:
# TODO: zabbix_ng::sender
Hi, thanks for your contribution! |
What does the kitchen CI actually test? We didn't implement any tests, did we? |
Thanks for the comments. Well mostly the things I forgot in code while already working on another branch/feature. I suppose they are now mostly fixed, except TODO, vs TODO: (anyway some removed in future PR). Kitchen verifier just now does nothing, except test for successful converge. In my wrapper I have now an recipe for simple mysql/(pgsql) database. I will consider to share these, but better into kitchen "test" cookbook & integration testing, than as a recipe in zabbix_ng (as everybody has different preferences regarding DB configuration). Wait a day or so before mege - as I still running "kitchen test". Anyway I will provide soon another PR for "rhel" platform family and a PR with zabbix version specified in attributes. These stacks in this order. |
well the tests passed on my side, the current conflict is due updates in your master now ( regarding zabbix_version attr ). BTW: can you pls share your idea about versioning, aka PR #3 is OK or the way it's done violate your personal flavors ;-) ? |
Added some basic kitchen CI configuration and yum repos + fixes to pass converge on centos 7.1.