Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kitchen CI & Yum repos #1

Closed
wants to merge 10 commits into from

Conversation

epcim
Copy link

@epcim epcim commented Feb 16, 2016

Added some basic kitchen CI configuration and yum repos + fixes to pass converge on centos 7.1.


suites:
- name: default
run_list:
- zabbix_ng::default
#- zabbix_ng::sender
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to either mark commented out blocks like this with a TODO or simply remove them altogether. Similar like this:

# TODO: zabbix_ng::sender

@chr4
Copy link
Member

chr4 commented Feb 16, 2016

Hi, thanks for your contribution!
I basically think this is good work and a good idea, I added some minor thoughts in the code comments.
Please review and add your thoughts!

@chr4
Copy link
Member

chr4 commented Feb 16, 2016

What does the kitchen CI actually test? We didn't implement any tests, did we?
If it doesn't actually check anything besides that the recipe runs through, we should split the kitchen CI into a seperate pull request and merge it later when there's actual integration/ unit tests available.

@epcim epcim mentioned this pull request Feb 19, 2016
@epcim
Copy link
Author

epcim commented Feb 23, 2016

Thanks for the comments. Well mostly the things I forgot in code while already working on another branch/feature. I suppose they are now mostly fixed, except TODO, vs TODO: (anyway some removed in future PR).

Kitchen verifier just now does nothing, except test for successful converge. In my wrapper I have now an recipe for simple mysql/(pgsql) database. I will consider to share these, but better into kitchen "test" cookbook & integration testing, than as a recipe in zabbix_ng (as everybody has different preferences regarding DB configuration).

Wait a day or so before mege - as I still running "kitchen test". Anyway I will provide soon another PR for "rhel" platform family and a PR with zabbix version specified in attributes. These stacks in this order.

@epcim
Copy link
Author

epcim commented Feb 25, 2016

well the tests passed on my side, the current conflict is due updates in your master now ( regarding zabbix_version attr ).

BTW: can you pls share your idea about versioning, aka PR #3 is OK or the way it's done violate your personal flavors ;-) ?

@chr4
Copy link
Member

chr4 commented Feb 26, 2016

Sorry, I'm a little confused by the many pull-requests. #3 seems to be the latest one? Or did you split them up? Can you close the ones that are not up to date please?
I'll comment on #3, as I think this is the current one. If I'm wrong, please advise :)

@epcim
Copy link
Author

epcim commented Mar 1, 2016

#3 is the latest, it's based on #2 and that on #1 (it would be too complex to split them as they interact). Sorry for confusion. My original aim was not to do much, but I ended up with three major updates as I was implementing it localy.

@epcim epcim closed this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants