-
-
Notifications
You must be signed in to change notification settings - Fork 110
Rust 1.0pre compat #195
base: master
Are you sure you want to change the base?
Rust 1.0pre compat #195
Changes from all commits
326097c
36c87f6
13b598a
031b145
24bc739
3c55d90
28dbc40
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#![feature(macro_rules, slicing_syntax)] | ||
#![feature(slicing_syntax, box_syntax, int_uint)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It'd be better to update these as appropriate rather than use the gates. |
||
|
||
use std::io::{File, Truncate, Write}; | ||
use std::os; | ||
|
@@ -12,7 +12,7 @@ fn main() { | |
Thread::spawn(move || { | ||
let output_dir = Path::new(os::getenv("OUT_DIR").unwrap()); | ||
read_method::generate(output_dir).unwrap(); | ||
}).detach(); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? I think what is actually desired here is to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, right now this will totally detach the thread and can leave things undone when main exits and all threads are killed. Either we should use |
||
|
||
let output_dir = Path::new(os::getenv("OUT_DIR").unwrap()); | ||
status::generate(output_dir).unwrap(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,9 @@ | |
|
||
#![allow(unknown_features)] | ||
#![feature(slicing_syntax)] | ||
#![feature(default_type_params)] | ||
#![feature(macro_rules)] | ||
#![feature(phase)] | ||
#![feature(globs)] | ||
#![feature(associated_types)] | ||
#![feature(old_orphan_check)] | ||
//#![feature(old_orphan_check)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be actually deleted. |
||
|
||
#[phase(plugin, link)] extern crate log; | ||
#[macro_use] extern crate log; | ||
extern crate url; | ||
extern crate time; | ||
extern crate collections; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The better transformation here is
&next_prefix[]
.