This repository has been archived by the owner on Aug 23, 2018. It is now read-only.
RFC 2616 -> RFC 7231 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference and quote the up to date RFC (7231) and not the deprecated (2616) one, rename some codes according to the current accepted naming.
| /// [RFC 2616, section 6.1.1 (Status Code and Reason | ||
| /// Phrase)](https://tools.ietf.org/html/rfc2616#section-6.1.1): | ||
| /// [RFC 7231, section 6 (Response Status Codes)] | ||
| /// (https://tools.ietf.org/html/rfc7231#section-6): |
There was a problem hiding this comment.
The body of this quotation has also changed and should be updated.
|
Did I forgot anything btw or you just didn't get around to merge? |
| @@ -4,7 +4,7 @@ use std::cmp::{PartialEq, Eq, PartialOrd, Ord}; | |||
| use std::fmt; | |||
| use std::mem::transmute; | |||
|
|
|||
| /// An HTTP status code (`Status-Code` in RFC 2616). | |||
| /// An HTTP status code (`Status-Code` in RFC 7231). | |||
There was a problem hiding this comment.
It’s actually status-code in RFC 7231, not Status-Code.
|
@brohee Sorry, I forgot about it and GitHub doesn’t notify me when you push new things—you can comment instead and that will make sure I hear. I’ve added just a couple more points. |
|
Sorry forgot to warn you it should be done. Tell me if any remaining issues |
|
merge conflicts here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference and quote the up to date RFC (7231) and not the deprecated (2616) one,
rename some codes according to the current accepted naming.