Skip to content

Commit

Permalink
subscription_list test: Set up whole ZulipApp, not just MaterialApp
Browse files Browse the repository at this point in the history
Just like we did for the InboxPage tests, in the previous commit.

Here, there's one test that failed on the assumption that a
particular icon was the only one in view; it apparently isn't
anymore (probably because of the page's back button), and that
assumption isn't important to the goal of the test. So, we adapt by
removing that assumption.

Related: zulip#393
  • Loading branch information
chrisbobbe committed Jun 18, 2024
1 parent 09193a0 commit 5285123
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions test/widgets/subscription_list_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:zulip/api/model/initial_snapshot.dart';
import 'package:zulip/api/model/model.dart';
import 'package:zulip/widgets/store.dart';
import 'package:zulip/widgets/app.dart';
import 'package:zulip/widgets/icons.dart';
import 'package:zulip/widgets/subscription_list.dart';
import 'package:zulip/widgets/unread_count_badge.dart';

Expand All @@ -28,12 +29,10 @@ void main() {
);
await testBinding.globalStore.add(eg.selfAccount, initialSnapshot);

await tester.pumpWidget(
MaterialApp(
home: GlobalStoreWidget(
child: PerAccountStoreWidget(
accountId: eg.selfAccount.id,
child: const SubscriptionListPage()))));
await tester.pumpWidget(const ZulipApp());
await tester.pump();
final navigator = await ZulipApp.navigator;
navigator.push(SubscriptionListPage.buildRoute(accountId: eg.selfAccount.id));

// global store, per-account store
await tester.pumpAndSettle();
Expand Down Expand Up @@ -185,7 +184,7 @@ void main() {
subscription,
], unreadMsgs: unreadMsgs);
check(getItemCount()).equals(1);
check(tester.widget<Icon>(find.byType(Icon)).color)
check(tester.widget<Icon>(find.byIcon(iconDataForStream(stream))).color)
.equals(swatch.iconOnPlainBackground);
check(tester.widget<UnreadCountBadge>(find.byType(UnreadCountBadge)).backgroundColor)
.equals(swatch);
Expand Down

0 comments on commit 5285123

Please sign in to comment.