Feature - Ability to extend the default patterns #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cliff notes (will expand in more detail in PR): 1. Added ability to pass in a patterns table and a overrideDefaults boolean. 2. Backwards compatible. 3. Updated README.
|
Good idea. It seems you have used a formatter on the readme, introducing lots of changes? Could you undo those, so the PR has a clean diff? |
chrisgrieser
approved these changes
Jan 2, 2024
|
No problem! Thanks for making a great plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to pass in a
patternstable and aoverrideDefaultsboolean into thecustomPatternstable. The changes are backwards compatible and type safe. Users can continue to use thecustomPatternsin the same way they are currently (no breaking changes). Or they can choose to use the new options to extend the default patterns with their own patterns.