Correcting an issue where prefixes weren't round-tripping correctly. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a persistent issue with the test suite, randomly failing a hypothesis example occasionally. I had some confusion in the string formatting for prefixed units, where the precedence would get out of whack. For example, when formatting `(Kilo*Meter)**2`, we'd format that as `Mm²` because a square kilometer is a million square meters; however the parsing would treat that as if it were a `(Mega*Meter)**2`. There were also a few more issues and a test flake in MathML formatting.
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 82
Lines 4344 4377 +33
Branches 655 664 +9
=========================================
+ Hits 4344 4377 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a persistent issue with the test suite, randomly failing a hypothesis
example occasionally. I had some confusion in the string formatting for
prefixed units, where the precedence would get out of whack. For example, when
formatting
(Kilo*Meter)**2, we'd format that asMm²because a squarekilometer is a million square meters; however the parsing would treat that as
if it were a
(Mega*Meter)**2. There were also a few more issues and a testflake in MathML formatting.