Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better dark mode #891

Open
wants to merge 7 commits into
base: 1.2.1-release
Choose a base branch
from

Conversation

nicolasbraun
Copy link

@nicolasbraun nicolasbraun commented Sep 5, 2023

What it si about

This PR is about trying to fix the dark modes issues reported mostly on Mac OS in issues #543 , #707 , #801.

How?

  • Add options to customise the header text colors
  • Adapt default based on the current system Dark mode status

Limitations

  • Does not handle mode switch during execution which can cause some text colors to automatically change (mostly the one not specifically set up and using WX defaults) while the background does not.

Note

Dis not really not again which branch to PR since the 1.0.8 seems to be the current stable release. It should probably be merged as an hotfix. Otherwise I'll try to fix conflicts with 1.21

@k-gruenberg
Copy link

This one should definitely be merged! It's such a nice tool/idea but pretty useless if you can't see anything with with light text on a light background (and there being no way to alter the font color)...

@dg-pb
Copy link

dg-pb commented Jan 22, 2025

Would be great if this was merged

@sbillinge
Copy link
Collaborator

@dg-pb @k-gruenberg @nicolasbraun I will look at this later today. @nicolasbraun this branch has become conflicted. Please could you resync it and repush? I didn't check what the conflict was but hopefully it is something small.

@sbillinge
Copy link
Collaborator

@nicolasbraun thanks so much for this PR!

I am about to work on a new release so I think it is better if can merge it into the 1.2.1-release branch, especially as this changes the pin of the wx version in requirements and I don't really want to do a hotfix that does that, just in case.

@nicolasbraun to make it easier to merge, please could you remove the style edits to top of the README. Of course, it is ok to add the edits that explain the new feature. If you like the style changes, feel free to put them on a separate PR.

I don't have easy access to a Mac so this would be way easier to review if you could grab screenshots of a gui and paste them into the comments. In particular, I am interested to see a more or less side-by-side comparison of what the GUI looks like now and after the change when it is using the default colors.

@nicolasbraun
Copy link
Author

Hello @sbillinge

I haven't touched gooey for a year as the related project to my PR was canceled.
I'll try to find a bit a time to make a dummy project and post some screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants