Add AnsiHtmlFormatter
#35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeldycke
force-pushed
the
ansi-html-formatter
branch
from
9d44eaa
to
9cbf97b
Compare
kdeldycke
force-pushed
the
ansi-html-formatter
branch
7 times, most recently
from
842002b
to
3b5f28d
Compare
|
All tests are passing and the code has been linted. @chriskuehl This PR is ready for review. |
|
👋 Hey @chriskuehl & @asottile, any news on my proposal from last month on my ready-to-use Ansi formatter for Pygments? 🤗 |
kdeldycke
force-pushed
the
ansi-html-formatter
branch
3 times, most recently
from
470b99f
to
82887bd
Compare
kdeldycke
force-pushed
the
ansi-html-formatter
branch
from
453df29
to
d14ef21
Compare
|
I just fixed the remaining issues. Tests are passing and this PR is ready to be merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplify the usage of the custom formatter a lot. To reflect this I extensively edited the
READMEand restructure it sopygments-ansi-coloris easier to approach.At this point,
ExtendedColorHtmlFormatterMixinis just becoming an implementation detail. You no longer need it directly as the user only needs to interact withAnsiHtmlFormatter. I took the liberty to add a deprecated message to its docstring.I also:
pygments-ansi-colorCloses #33.