Updates for Bitbucket 8.x

[eeijlar]

Hi Christian,

I have made some updates to your plugin to support Bitbucket 8.x.

Note:
I haven't had time to do the changes for the File Name plugin, only the File Size plugin so far. I hope to get to the File Name one in a future PR.

Regards
John

[christiangalsterer]

Hi John, Thank you very much for providing a pull request. Unfortunately I was very busy in the last months and was not able to keep the plugin update as in the past. Therefore it is highly appreciated that you volunteered and spend your time to provide this pull request. I’m still a few mire days busy but will look into it end of next week. Thanks again Christian

…

On 11. Apr 2019, at 12:06, John ***@***.***> wrote: Hi Christian, I have made some updates to your plugin to support Bitbucket 6.x. Note: I haven't had time to do the changes for the File Name plugin, only the File Size plugin so far. I hope to get to the File Name one in a future PR. Regards John You can view, comment on, or merge this pull request online at: #53 Commit Summary First round of changes to support new Bitbucket api Add .gitignore file Updated dependencies and code changes, updated pom.xmls, commented FileName hook for the moment Final changes Comment FileName plugin stuff for the moment, haven't had time to update that File Changes A .gitignore (2) A .idea/compiler.xml (13) A .idea/vcs.xml (6) M pom.xml (56) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/CatFileBatchCheckHandler.java (2) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/FileNameHook.java (98) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/FileSizeHook.java (120) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/FileSizeHookValidator.java (7) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/GitUtils.java (5) M src/main/java/org/christiangalsterer/stash/filehooks/plugin/hook/MergeBaseResolver.java (11) M src/main/resources/atlassian-plugin.xml (4) M src/test/java/org/christiangalsterer/stash/filehooks/plugin/hook/FileNameHookTest.java (7) Patch Links: https://github.com/christiangalsterer/stash-filehooks-plugin/pull/53.patch https://github.com/christiangalsterer/stash-filehooks-plugin/pull/53.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[paderka]

Is there still an issue that doesn't allow to merge?

[xirixiz]

Hi Christian,

Currently I`m migrating to version 6.x, hope you can merge this request any time soon. Thanks!

Regards,
Bram

[praiv]

Hi Christian,

Just a kind reminder to approve and to merge the PR's

I believe many of us are waiting for it.

Thanks.

[mkgl]

Hi @eeijlar,

Thought you might want to remove these couple compiler/vcs.xml files from your first commit; the .gitignore was introduced afterwards, it doesn't retroactively apply. :)

In case those little details help moving forward,

[eeijlar]

I have removed and update the pull request. I am stunned that anyone is even looking at this.

Thanks for the comments @mkgl

[mkgl]

here's a tiny mis-indentation

[eeijlar]

fixed!

[catalinFlorea]

Can this pull request be approved? We really need this plugin.

[focbenz]

Could be compiled by anyone with the Atlassian SDK and then installed as JAR in den Bamboo Server instance ... but would also appreciate an official merge and release.

[eeijlar]

Branch creation is very slow now. It's looking at the entire commit history. The getChanges method is taking 4 seconds to execute on one repository where I am creating a branch. These must be related to Bitbucket 8.x

I also don't understand why branch creation triggers the hook in the first place. There would be no new files on a branch creation.

In my case there was a file checked into the repository 2 years ago which violates the size requirements of the hook, and it is failing branch creation for that reason:

I don't really care about previous violations though, that was an accidental check-in.

Any thoughts @raspy , @christiangalsterer

[eeijlar]

Branch creation is very slow now. It's looking at the entire commit history. The getChanges method is taking 4 seconds to execute on one repository where I am creating a branch. These must be related to Bitbucket 8.x

I also don't understand why branch creation triggers the hook in the first place. There would be no new files on a branch creation.

In my case there was a file checked into the repository 2 years ago which violates the size requirements of the hook, and it is failing branch creation for that reason:

I don't really care about previous violations though, that was an accidental check-in.

Any thoughts @raspy , @christiangalsterer

I have fixed this problem, when I was collecting the refs from the repository I wasn't doing anything with them. They should have been added to a set of refs.

[christiangalsterer]

First of all thank you for the contributions. I didn't had time to look into this for quite a while so I'm really happy for the contributions. As I haven't done any release for quite some time I need to figure out what the current regulations in the Atlassian Marketplace are.