-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dummy object to designate "uninitialized" networks (fixes #511) #525
Open
acolomb
wants to merge
16
commits into
christiansandberg:master
Choose a base branch
from
acolomb:dummy-network
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2645ee3
Add a _DummyNetwork class to designate "uninitialized" networks.
acolomb 8537557
Break import cycle.
acolomb 0a2f169
Even easier fix, move _DummyNetwork import to constructor.
acolomb 2f3d763
Even simpler import cycle avoidance.
acolomb 47f572c
Provide a more useful exception message in _DummyNetwork.
acolomb 79473f9
Merge branch 'master' into dummy-network
acolomb a318e0b
Annotate node.BaseNode.network and avoid None dummy value.
acolomb 2e01485
Avoid None dummy value in node.RemoteNode.network.
acolomb 1c56ec1
Annotate emcy.EmcyProducer.network and avoid None dummy value.
acolomb d6c7ee0
Annotate sdo.SdoBase.network and avoid None dummy value.
acolomb d2952f5
Annotate lss.LssMaster.network and avoid None dummy value.
acolomb ab516b8
Harmonize import of network.Network in NmtBase.
acolomb 378835e
Avoid None dummy value in pdo.PdoBase.network.
acolomb 24560d0
Rename to _UninitializedNetwork, use singleton instance.
acolomb b89270a
Final
acolomb 8bad311
Merge branch 'master' into dummy-network
acolomb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the naming. I'd prefer if the naming more closely reflected it's purpose:
_NetworkPlaceholder
_UninitializedNetwork
_EmptyNetwork