Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured bindings #326

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

christophebedard
Copy link
Owner

We use a lot of std::pair<>, so this simplifies the unpacking code. See: https://en.cppreference.com/w/cpp/language/structured_binding.

@christophebedard christophebedard self-assigned this Mar 9, 2024
Signed-off-by: Christophe Bedard <[email protected]>
@christophebedard christophebedard force-pushed the christophebedard/use-structured-bindings branch from 722aa4b to 8df9ae5 Compare March 9, 2024 22:05
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (rolling@f7ead0f). Click here to learn what that means.

Files Patch % Lines
email/src/service_client.cpp 0.00% 0 Missing and 2 partials ⚠️
email/src/service_server.cpp 0.00% 0 Missing and 1 partial ⚠️
rmw_email_cpp/src/rmw_request.cpp 0.00% 1 Missing ⚠️
rmw_email_cpp/src/rmw_response.cpp 0.00% 1 Missing ⚠️
rmw_email_cpp/src/take.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             rolling     #326   +/-   ##
==========================================
  Coverage           ?   35.99%           
==========================================
  Files              ?       87           
  Lines              ?     2834           
  Branches           ?      704           
==========================================
  Hits               ?     1020           
  Misses             ?     1257           
  Partials           ?      557           
Flag Coverage Δ
email 60.96% <0.00%> (?)
rmw-email-cpp 0.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophebedard christophebedard merged commit 9e1e94d into rolling Mar 9, 2024
5 checks passed
@christophebedard christophebedard deleted the christophebedard/use-structured-bindings branch March 9, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant