Skip to content

Commit

Permalink
[BUG]: Fix for failing chromadb-client build (#1561)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Python client build has not been working for a few releases now.
Appears that `build` module is not longer available in default GH runner
setup and needs to be explicitly installed

## Test plan
*How are these changes tested?*

Manual test:

```bash
python -m pip install -r ./clients/python/requirements.txt && python -m pip install -r ./clients/python/requirements_dev.txt
....
Installing collected packages: sortedcontainers, pypika, websockets, uvloop, sniffio, pyyaml, python-dotenv, pluggy, packaging, opentelemetry-util-http, iniconfig, httptools, h11, click, attrs, asgiref, uvicorn, pytest, hypothesis, anyio, watchfiles, starlette, opentelemetry-instrumentation, opentelemetry-instrumentation-asgi, fastapi, opentelemetry-instrumentation-fastapi
Successfully installed anyio-3.7.1 asgiref-3.7.2 attrs-23.1.0 click-8.1.7 fastapi-0.105.0 h11-0.14.0 httptools-0.6.1 hypothesis-6.92.1 iniconfig-2.0.0 opentelemetry-instrumentation-0.43b0 opentelemetry-instrumentation-asgi-0.43b0 opentelemetry-instrumentation-fastapi-0.43b0 opentelemetry-util-http-0.43b0 packaging-23.2 pluggy-1.3.0 pypika-0.48.9 pytest-7.4.3 python-dotenv-1.0.0 pyyaml-6.0.1 sniffio-1.3.0 sortedcontainers-2.4.0 starlette-0.27.0 uvicorn-0.18.3 uvloop-0.19.0 watchfiles-0.21.0 websockets-12.0

sh ./clients/python/build_python_thin_client.sh
/Users/tazarov/experiments/chroma-experiments/oss/boto3-issue/.venv/bin/python: No module named build

pip install build

Installing collected packages: pyproject_hooks, build
Successfully installed build-1.0.3 pyproject_hooks-1.0.0

./clients/python/build_python_thin_client.sh
* Creating venv isolated environment...
* Installing packages in isolated environment... (setuptools>=61.0, setuptools_scm[toml]>=6.2)
* Getting build dependencies for sdist...
...
Successfully built chromadb-client-0.1.dev1011.tar.gz and chromadb_client-0.1.dev1011-py3-none-any.whl

```
## Documentation Changes
N/A
  • Loading branch information
tazarov authored Dec 22, 2023
1 parent 9fc442f commit 12785d7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions clients/python/requirements_dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ opentelemetry-instrumentation-fastapi>=0.41b0
pypika==0.48.9
pytest
uvicorn[standard]==0.18.3
build

0 comments on commit 12785d7

Please sign in to comment.