Skip to content

Commit

Permalink
[CHORE]: Moved mypy config from .ini to pyproject.toml (#1663)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - minor reducing the number of config files to maintain

## Test plan
*How are these changes tested?*

- [x] Tested with pre-commit hooks (works also for ignoring grpc proto
dir)

## Documentation Changes
N/A
  • Loading branch information
tazarov authored Jan 25, 2024
1 parent 9394199 commit 279373c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ repos:
rev: "v1.2.0"
hooks:
- id: mypy
args: [--strict, --ignore-missing-imports, --follow-imports=silent, --disable-error-code=type-abstract, --config-file=./mypy.ini]
args: [--strict, --ignore-missing-imports, --follow-imports=silent, --disable-error-code=type-abstract, --config-file=./pyproject.toml]
additional_dependencies: ["types-requests", "pydantic", "overrides", "hypothesis", "pytest", "pypika", "numpy", "types-protobuf", "kubernetes"]
2 changes: 0 additions & 2 deletions mypy.ini

This file was deleted.

7 changes: 7 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ target-version = ['py38', 'py39', 'py310', 'py311']
[tool.pytest.ini_options]
pythonpath = ["."]

[tool.mypy]
ignore_errors = false

[[tool.mypy.overrides]]
module = ["chromadb.proto.*"]
ignore_errors = true

[project.scripts]
chroma = "chromadb.cli.cli:app"

Expand Down

0 comments on commit 279373c

Please sign in to comment.