Skip to content

Commit

Permalink
Install Atlas in Coordinator's Docker container (#1472)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Install Atlas in the Coordinator's Docker container and copy the
migrations. This makes it easy to run migrations before deploys.
	 - Removed bash autocomplete from the Coordinator's Dockerfile.

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js
- [x] Manually built the image, ran it, and ran migrations against a
fresh database running locally in postgres

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
  • Loading branch information
beggers authored Dec 7, 2023
1 parent 88db738 commit 755a69b
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion go/coordinator/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,20 @@ FROM alpine:3.17.3

RUN apk add --no-cache bash bash-completion

# As of 6 Dec 2023, the atlas package isn't in Alpine's main package manager, only
# testing. So we have to add the testing repository to get it.
RUN apk add \
--no-cache \
--repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \
--repository http://dl-cdn.alpinelinux.org/alpine/edge/main \
atlas

RUN mkdir /chroma-coordinator
WORKDIR /chroma-coordinator

COPY --from=build /src/chroma-coordinator/bin/chroma /chroma-coordinator/bin/chroma
ENV PATH=$PATH:/chroma-coordinator/bin

RUN chroma completion bash > ~/.bashrc
COPY --from=build /src/chroma-coordinator/migrations /chroma-coordinator/migrations

CMD /bin/bash

0 comments on commit 755a69b

Please sign in to comment.