Skip to content

Commit

Permalink
[BUG] Fix config in go service to use default bind address. reverts p… (
Browse files Browse the repository at this point in the history
#1564)

Reverts part of #1553

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Use the default bind addr in go cmd line
 - New functionality
	 - /

## Test plan
*How are these changes tested?*
Manually minikube

## Documentation Changes
None
  • Loading branch information
HammadB authored Dec 22, 2023
1 parent 7dfadf4 commit 95ad316
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion go/coordinator/cmd/grpccoordinator/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"io"
"time"

"github.com/chroma/chroma-coordinator/cmd/flag"
"github.com/chroma/chroma-coordinator/internal/grpccoordinator"
"github.com/chroma/chroma-coordinator/internal/grpccoordinator/grpcutils"
"github.com/chroma/chroma-coordinator/internal/utils"
Expand All @@ -26,7 +27,7 @@ var (
func init() {

// GRPC
Cmd.Flags().StringVar(&conf.GrpcConfig.BindAddress, "grpc-bind-address", "", "GRPC bind address")
flag.GRPCAddr(Cmd, &conf.GrpcConfig.BindAddress)

// System Catalog
Cmd.Flags().StringVar(&conf.SystemCatalogProvider, "system-catalog-provider", "memory", "System catalog provider")
Expand Down

0 comments on commit 95ad316

Please sign in to comment.